search

philipmw / phrase.shop

A web app to generate secure yet memorable passphrases
https://phrase.shop
MIT License
4 stars 3 forks source link

Upgrade to webpack 5 #23

Closed 0xln closed 4 years ago

0xln commented 4 years ago

To address Upgrade to webpack 5 issue.

0xln commented 4 years ago

In the spirit of hacktoberfest, please can the label hacktoberfest-accepted be added to this PR

philipmw commented 4 years ago

@0xln thank you for your contribution -- I am excited to receive it!

I tested npm start and that works well, but it no longer auto-opens a browser window. I kinda like that, though. The bigger issue is that npm run build no longer works. It gives this error:

[webpack-cli] Unknown argument: --display-error-details

I am quite sure I can fix this myself, but I figure it's best if you fix it so we can merge a fully functional pull request from you.

Would you please fix npm run build?

Thank you, looking forward to the next revision!

philipmw commented 4 years ago

FYI, I added the "hacktoberfest" topic to this repo.

0xln commented 4 years ago

Going to make an adjustment to get the npm build step sorted and once that is done, the PR should be all good. Thanks for adding hacktoberfest to the topic!

philipmw commented 4 years ago

Thanks very much for your contribution, 0xln! I hope you get and enjoy that t-shirt. :)