search

philipmw / phrase.shop

A web app to generate secure yet memorable passphrases
https://phrase.shop
MIT License
4 stars 3 forks source link

Add US Airport codes as option #24

Closed 0xln closed 4 years ago

0xln commented 4 years ago

Added airport codes as a phrase type, taken from Passenger Boarding (Enplanement) and All-Cargo Data for U.S. Airports Airports.

Addresses issue Add airport codes as a phrase part type

philipmw commented 4 years ago

Hey there, @0xln! Happy weekend!

Thanks for the PR. I have two concerns.

One, you are adding about 522 airports. I believe that's still too many for good memorization, and I'd prefer to have that number reduced to just the most popular airports. For example, the top 16, or at most the top 32. That feels like a good tradeoff between variety and memorability.

Two, the number of entropy bits this word type is advertising does not match reality. You are advertising 4 bits, which allows for 16 possibilities, but you're adding 522 airports. The actual number of bits right now is about 9, which is log-base-2 of 522.

If it was me, I'd keep the number of bits advertised as-is at 4, and reduce the number of airports in the wordbank to the top 16 commercial airports. How do you feel about that?

Did you type all those by hand? 🤭

0xln commented 4 years ago

I did a quick cut and paste job, so not typed by hand thankfully! I've adjusted the airports to the top 16, so that it matches the entropy provided and makes them slightly more memorable. Maths never was my strong point 🙃

philipmw commented 4 years ago

Nice! Can you just double-check that coverage/lcov.info does not need to change with your latest commit?

0xln commented 4 years ago

Yep, looks like it did need an update. Fixed!

philipmw commented 4 years ago

Woohoo!