philipmw / phrase.shop

A web app to generate secure yet memorable passphrases
https://phrase.shop
MIT License
4 stars 3 forks source link

Fix interaction between sentence templates and dice entropy #33

Closed philipmw closed 2 years ago

philipmw commented 2 years ago

In phrase.shop v1, you'd first build a phrase from parts (which requires no entropy), then generate it (which does). With dice entropy, the app would let you build the phrase but keep the Generate button disabled until you roll the dice enough times. This ensured we don't try to generate the phrase until we have enough entropy.

In v2, building and generating are combined into one step, but the entropy check now happens at the wrong time and for the wrong amount.