search

philipnilsson / badness

4 stars 2 forks source link

Inaccuracy in sampledBy explanation #1

Closed egirshov closed 11 years ago

egirshov commented 11 years ago

Thanks for great article and a nice demo! There is a small inaccuracy in sampledBy example 

streamA.sampledBy(streamB)

which is incorrect as only Property could be sampled, not an EventStream

philipnilsson commented 11 years ago

Glad you liked the article. I purposefully left out mentioning the distinction between properties and event stream in this article as it doesn't really flow very well into the discussion and it's a tutorial level.

I've actually not entirely happy with the fact that Property/EventStream have different operations on them in bacon, and opened this issue https://github.com/baconjs/bacon.js/issues/242.

Pending on the result of that discussion I'll adress this in the post.

Thanks for the feedback!