philipp-winterle / crittr

High performance critical css extraction with a great configuration abilities
https://hummal.github.io/crittr/
GNU General Public License v3.0
51 stars 6 forks source link

Crittr should terminate command line process when it fails #10

Closed teles closed 5 years ago

teles commented 6 years ago

Is your feature request related to a problem? Please describe. I'm using crittr to generate critical css for deployment. The deployment process follows these steps:

The problem:

Sometimes Crittr fails to generate critical css and the deployment continues. In this case I would like to make sure that the deployment will fail if the critical css is not properly generated.

Describe the solution you'd like

I would like to have an option to make Crittr terminate command line process if it fails.

philipp-winterle commented 6 years ago

Thanks for sharing. Can you provide an error message occuring in your case? Means: why is the css not properly generated?

teles commented 5 years ago

Hi, i just solved this problem calling an exit(1) if generated critical fails.