search

philipp-winterle / crittr

High performance critical css extraction with a great configuration abilities
https://hummal.github.io/crittr/
GNU General Public License v3.0
51 stars 6 forks source link

Updated all packages #14

Closed grommas closed 3 years ago

grommas commented 3 years ago

Updated all packages, therefore I replaced the deprecated waitFor() with waitForTimeout() from puppeteer. css-mqpacker@7.0.0 was no longer supported. Updated to another repro of hail2u.

philipp-winterle commented 3 years ago

Thx @grommas. I will make some tests and merge if everything is okay.

Iam al little nervous about the css-mqpacker. He disappeared and alternatives were build and then he came back and never answered any questions. In the meantime we got things like https://github.com/solversgroup/postcss-sort-media-queries which are doing the same and being more trustful to me. It is also not clear why he refuse to provide a npm package. Code seems to be safe but we don't know what happens in a year or when someone is overtaking the account of him. Not feeling good with it.

On the other hand it would mean switching from clean-css to postcss to use the plugin, which is additional effort.

I will think about it.