Instances of puppetter not getting closed/killed

philipp-winterle / crittr

High performance critical css extraction with a great configuration abilities

https://hummal.github.io/crittr/

GNU General Public License v3.0

51 stars 6 forks source link

Instances of puppetter not getting closed/killed #43

Closed Creativico closed 1 year ago

Creativico commented 1 year ago

Description: Really simple, if you run many site urls through crittr within a span of few seconds you will get a bunch of puppetter processes open as they don't close.

https://jumpshare.com/v/017bMHfJYHkz1OBqCkmd

How to reproduce the issue? I'm running 50 site urls per minute (approx) and after few minutes crittr processes keep hanging and clog up the server.

Expected behavior Processes should die when the script ends

Screenshots https://jumpshare.com/v/017bMHfJYHkz1OBqCkmd

philipp-winterle commented 1 year ago

False positive?

Creativico commented 1 year ago

Sorry, just took a look on different VPS and it's not producing the issue so far. I'm monitoring but seems everything is identical (version of OS, components..) but the issue does not repeat. So I closed until I verify on new VPS instances.