search

philippabele / deep-groove-with-pytorch

0 stars 1 forks source link

First steps with pytorch #16

Closed RicoKursidem closed 1 year ago

RicoKursidem commented 1 year ago

I added the project folder and added a tutorial folder for the pandas and PyTorch folders. I will continue with the tutorial in the following days

this pull request will resolve #13

philippabele commented 1 year ago

@RicoKursidem Jupyter Notebooks are great to play around with data, but they are terrible to handle in a repo.

I will approve this PR, because it is only a tutorial. But for the main application we have to move away from notebooks to pure python. In order to see your actual work faster during code reviews, this will improve the speed and quality of my support for your project.

The reuse of your source code in future projects will also be easier, if the code is split into pure application code and pure python classes. Jupyter Notebooks will only be used for demo purpose.

Is this okay for you?

RicoKursidem commented 1 year ago

Hi @philippabele

I just used the notebooks as a place to do the tutorial and save code snippets for later use. I'm fine with the approval of this pull request, but I didn't finish the tutorial yet. I plan to complete it tomorrow.

I can also add the PyTorch tutorial notebooks to the .gitignore and use them only on my system.

I'm aware that I should work with classes and an IDE that supports this kind of coding better than VS Code. Is it ok if I use PyCharm to develop this Project, or is there a better IDE?

philippabele commented 1 year ago

I work with VS Code and value it.

There are plenty of extensions to fit it to your personal use case.

RicoKursidem commented 1 year ago

I did all tutorials and added a Jupyter file to document them.

I also made this pull request ready for review, and it can be merged to the main branch now