search

philippe44 / AirConnect

Use AirPlay to stream to UPnP/Sonos & Chromecast devices
Other
3.55k stars 218 forks source link

reserved identifier violation #128

Closed elfring closed 5 years ago

elfring commented 5 years ago

I would like to point out that identifiers like “__AIRCAST_H” and “_STR_LEN_” do not fit to the expected naming convention of the C language standard. Would you like to adjust your selection for unique names?

philippe44 commented 5 years ago

Well, I hear you but I started like that, all my headers are following the same "old" logic . AirConnect is a simple application that is not a library or mission critical (see my other comment) so I don't have the patience to do all these changes just for better style, knowing that all this work I'm doing is night & week-ends time

elfring commented 5 years ago

How do you think about to avoid that this software depends on undefined behaviour?

philippe44 commented 5 years ago

Ok - you sound like a troll or a bot. I'll give you one chance to make a proper response and then I'll close that issue