philippe44 / AirConnect

Use AirPlay to stream to UPnP/Sonos & Chromecast devices
Other
3.51k stars 217 forks source link

Add '-o' option to include only specific model numbers in airupnp #205

Closed pwt closed 4 years ago

pwt commented 4 years ago

This is a PR to address https://github.com/philippe44/AirConnect/issues/204.

The code has been compiled, but not tested -- as I struggle to maintain a functional build environment for AirConnect. Apologies for this; I'm happy to test any builds that get created.

philippe44 commented 4 years ago

Do you think you could squash all the commits together?

pwt commented 4 years ago

Usually, I think the committer chooses ‘squash and merge’ when merging the PR, making it a single commit on the target branch: https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/merging-a-pull-request#merging-a-pull-request-on-github

The repo must allow squash merging: https://help.github.com/en/github/administering-a-repository/configuring-commit-squashing-for-pull-requests

If this doesn’t work for you for some reason, I’m happy to cancel the PR and create a new one.

philippe44 commented 4 years ago

I can do that, it's just easier for me to view the patch as one item when possible. If you squash your commits on your fork, they will appear to me as one, I think (this is what I do usually). You don't have to submit a new PR

pwt commented 4 years ago

it's just easier for me to view the patch as one item when possible

But that's easy: you just click on 'files changed' above (https://github.com/philippe44/AirConnect/pull/205/files). That consolidates the changes. Then, you just squash merge.

philippe44 commented 4 years ago

Now you know I'm a very casual user of GitHub :-)

pwt commented 4 years ago

Thanks @philippe44.

I'm no GitHub expert either, it's just that I've gone through the process of landing changes in another repo quite recently, so I had to comprehend the process :)

I'll do some testing of this option once you do your next builds. Assuming it passes, I'll close #204.