search

philippe44 / LMS-ShairTunes2W

Airtunes with LMS (fork of https://github.com/disaster123/shairport2_plugin)
65 stars 3 forks source link

Setting LMS host ip not completely done for all connections? #41

Open chincheta0815 opened 2 years ago

chincheta0815 commented 2 years ago

Hi Philippe,

I am trying to set LMS and all parts of it to a defined IP address using all command line args I could find (meaning --httpaddr, --clientaddr, --playeraddr, --streamaddr, ...). What came out was that I could get manage to change that ip for all "LMS base" services.

I found out that 2 open (random-numbered) ports still listen on "0.0.0.0" and that they belong to the ShairTunes plugin.

By adding LocalAddr => Slim::Utils::Network::serverAddr(),

to "Plugins.pm" right under the lines https://github.com/philippe44/ShairTunes2/blob/c78afc244d2adfe3e90fa4438fb5eab33ec9d93c/plugin/Plugin.pm#L253 and https://github.com/philippe44/ShairTunes2/blob/c78afc244d2adfe3e90fa4438fb5eab33ec9d93c/plugin/Plugin.pm#L390 I got all LMS parts listen correctly...

If that is kind of an improvement to ShairTunes just tell me and I can do a PR. Probably I also do not see how things work together correclty, then please tell me.

Thanks in advance.

Best regards

Rouven