search

philippe44 / LMS-YouTube

Play YouTube videos on LMS
38 stars 15 forks source link

Missing install.xml #1

Closed michaelherger closed 9 years ago

michaelherger commented 9 years ago

There's no install.xml file in git. Is this by purpose? After all it should always have the same UUID etc.

philippe44 commented 9 years ago

You mean a repository install file ? Yes, that would be on purpose because the packaged installation is on sourceforge. I did that because GitHub only accepts HTTPS for download and some Linux LMS installation do not have SSL. I know this is needed ultimately for YouTube but this is the model I took for plugin on my UPnP plugin as this one does not require SSL to work

michaelherger commented 9 years ago

No, the install.xml file needed to be included in the zip-file. Without that file the plugin wouldn't be loaded by LMS. When I tried to run it from a git clone it didn't work until I copied install.xml from the zip file.

philippe44 commented 9 years ago

Oh then this is a mistake - I probably have a .gitignore that excludes XML files. Corrected now. There was also a small update that I forgot to commit

michaelherger commented 9 years ago

Fixed, thanks!