philippe44 / lms-deezer

MIT License
36 stars 8 forks source link

Flow issues #49

Open lanne33 opened 4 months ago

lanne33 commented 4 months ago

Playing Flow inside the Flow menu is working fine but playing Flow from the main menu causes LMS (8.5.2 - 1716215514) to crash.

philippe44 commented 4 months ago

Should be fine in 3.0.4

lanne33 commented 4 months ago

Same bad behavior with 3.0.4

lanne33 commented 4 months ago

Dunno if the following have any usefulness:

[24-06-28 12:50:38.1591] Plugins::Deezer::API::Async::_get (1201) Getting /user/me/flow?limit=10 [24-06-28 12:50:38.2343] Plugins::Deezer::ProtocolHandler::ANON (305) acquired 0 radio tracks for user/me/flow [24-06-28 12:50:38.2345] Plugins::Deezer::ProtocolHandler::getNextTrack (299) need to fetch more radio tracks for user/me/flow

philippe44 commented 4 months ago

Should be fixed now

lanne33 commented 4 months ago

It is. Merci Philippe.

ewok2 commented 4 months ago

Hello, Flow was not working since 3 days In my plugin installed the plugin was no more there I put it again by adding "https://github.com/philippe44/lms-deezer/blob/main/repo/repo.xml" the bottom ofmanage plugin page. now plugin is there but only [Continue streaming] works ? (with a delay of some second befor strating) Any idee how to get a full deezer back on LMS?

I have Logitech Media Server Version: 8.5.1 - 1710430218 Does I need to go to the 8.5.2 ?

Thanks

lanne33 commented 4 months ago

Why not try 8.5.2 and see? Flow is working fine for me. Just had to restart LMS today after a Flow failure.

ewok2 commented 4 months ago

Because I prefer not to perform update by hazard ;-) But I have perform the 8.5.2 update and it is not better...

ewok2 commented 4 months ago

I was wondering if it is possible to install an "old" version of the plugin ?

ewok2 commented 4 months ago

Just for information Without modifing anything it work again??? MAybe an evolution on Deezer side? But in this case why am I alone to have problem?

lanne33 commented 4 months ago

Just for information Without modifing anything it work again??? MAybe an evolution on Deezer side? But in this case why am I alone to have problem?

LMS + Deezer plugin suffers from a random (seems to be) LMS crash. Restarting LMS bring the service back. I myself have to restart LMS every day.

ewok2 commented 4 months ago

Don't kown if I get this problem, but i my case a restart LMS or a reboot of the VM does not solve the problem

philippe44 commented 4 months ago

I don't know what problem you are really referring to guys

lanne33 commented 4 months ago

Philippe, the wrong behavior is that at some point when you select a Deezer track and click the play button, LMS starts to search for 2-3 seconds, and then nothing, the play button goes back to stop. Click again and same wrong behavior again. The only way to recover the right behavior is to restart LMS.

And the logs associated to the wrong behavior described above are the following. Can you spot something wrong in it?

[24-07-06 11:03:11.0681] Plugins::Deezer::API::Async::gwCall (809) context will expire in 981950 [24-07-06 11:03:11.0685] Plugins::Deezer::API::Async::_ajax (871) POST ?api_token=DB3HH_EL-2eSAJYsSy.LWz-g_jBTilN-&api_version=1.0&input=3&method=song.getListData "{\"sng_ids\":[\"2218397\"]}"

ewok2 commented 4 months ago

Hello Philippe I had some weeks ago the same behavior describe by lane33. For this behavior on my side a reboot of the LMS VM does not solve imediatly the problem but after some hour the normal behavior come back again. (Look like a kind of network IP ban during a certain time?)

But 5 day ago I had another behavior When trying to play deezer flow the time of the track increase but no title nor cover nor sound is pay... and the time increase whitout stoping. I try to have a look in the "/var/log/squeezeboxserver/sever.log" but did not find a error... Will have to look more precisely next time it will apear.

lanne33 commented 4 months ago

But 5 day ago I had another behavior When trying to play deezer flow the time of the track increases but no title nor cover nor sound is pay... and the time increase whitout stoping. I try to have a look in the "/var/log/squeezeboxserver/sever.log" but did not find a error... Will have to look more precisely next time it will apear.

Got the exact same behavior with the Flow. The time of the track increases but no title nor cover nor sound is playing... and the time increases without stopping. And it can't be stopped. Clicking stop button doesn't work, time continue to increase. Only an LMS restart solves the problem.

ewok2 commented 4 months ago

Thanks lanne33 always more confortable not to be the only one with an error ;-) My only difference with you, when I restart LSM it does not solved the problem... When you talk about restart lsm you mean (if your server is on linux?) a "sudo service logitechmediaserver restart" ?

lanne33 commented 4 months ago

I'm doing it with Picoreplayer interface but I suspect it's the same linux command as yours.

philippe44 commented 4 months ago

There are tokens that are supposed to only be valid for a given amount of time, but I'm pretty sure it's not as long as what the API returns. That explains the behavior where only a LMS restarts fixes a non-responsive (nothing plays) plugin. But there are probably more issues.

philippe44 commented 4 months ago

I've pushed a version with shorter token expiration

Ds5-44 commented 4 months ago

Hi everyone. As @lanne33 and @ewok2 I got the same behaviour with Flow or Playlists. Restarting seems indeed to solve the problem but in my case, it doesn't last very long and this morning after only one track in the playlist, I had to restart LMS. Just read all what you've said before . I guess there was a change at Deezer side, because everything was working fine since the beginning and everyone was very happy to hear Deezer again after the end of the MySqueezebox.com Servers !! so I hope the new version will solve this. Do you know how long does it take to see the update in the plugins tab in LMS ? Thanks @philippe44 for all this job.

lanne33 commented 4 months ago

@Ds5-44 it's in the repo: https://raw.githubusercontent.com/philippe44/lms-deezer/main/repo/repo.xml

ewok2 commented 4 months ago

Thanks Philippe for all your job. You have saved my audio multiroom instalation with your Deezer plugin.

I have installed the 3.1.1 but It still strange. The flow does not work again, but "home/continue streamin" or "mixed inspired by ..." still works Even after a LSM restart or the VM reboot. I expect as the oter times flow will come back tomorow... I will let you know. (by the way noting in the server.log)

If you have other version to test don't hesitate ;-)

ewok2 commented 4 months ago

Maybe a coincidence maybe a start for the bug. I have 2 players synchronise ("Salon" & "Cuisine" with Salon as "master") When I have try Flow it was with "Salon" selected on the web control. I have try flow with "Cuisine" selected on the web control and it has worked...

(Or it is only the time between the two try that have chage, and link to the token lifetime you have changed?)

But everythings works again perfectly !

Ds5-44 commented 4 months ago

Hello. I've just update to 3.1.1 without restarting LMS server before. I think the server wasn't working for Flow/playlist before the update, and after update without restarting LMS, when trying the first Deezer playlist seems to work fine ! Same for Flow ! I'll probably try again tomorrow on other speakers and during much more time (tonight I only made a quick test to tell you if it was also working for me or not). After that, if something goes wrong, i'm sure my daughters will tell me quickly !!! ;) Thanks very much for the update, seems good so far Did you manage to understand why this behaviour occurs since about 2 weeks ago because for me v3.1.0 was working perfectly since the beginning and I don't remember having making changes on LMS or Deezer plugin or anything else regarding my multiroom audio settings ?

Ds5-44 commented 3 months ago

Hi, a short message to tell you that everything is working perfectly this morning. I tried Flow and a playlist on two different speakers and everything started well without trouble and I don't have to restart LMS at all ! Again, many thanks, have a nice day