search

philippec / PhFacebook

MacOSX Interface to Facebook graph API
http://developer.casgrain.com/?p=107
Other
178 stars 44 forks source link

Added parameters to sendRequest #6

Closed infiniteNIL closed 13 years ago

infiniteNIL commented 13 years ago

Hi Phillip,

I needed to include some parameters to my friends request so I added a sendRequest:parameters method, changed sendRequest: to call sendRequest:parameters: and changed sendFacebookRequest: to use the parameters.

I think it would make a good addition as I'm sure others need to send parameters as well. I'm surprised it wasn't already there.

philippec commented 13 years ago

Sounds great! Can you please adjust your patch so it matches the coding style of the surrounding functions? I think it's 2 spaces per tabs (no tabs), braces go on their own line and I'm a bit particular about the spacing for parameters and stuff. Just take a look at the rest and be consistent.

Thanks!

infiniteNIL commented 13 years ago

Ok, I adjusted the spacing and formatting.

philippec commented 13 years ago

Thank you! Looks great. I will integrate as soon as I have a few moments to do it properly.