search

philippelt / netatmo-api-python

Netatmo connect API python client (for Netatmo information, see https://dev.netatmo.com)
GNU General Public License v3.0
191 stars 120 forks source link

User specific rate limits #39

Closed joebe975 closed 4 years ago

joebe975 commented 4 years ago

I added some functionality according to feedback/proposals from @philippelt. One can now specify the rate limits as argument to the script and the default values are set to lower than the maximum. I also added documentation as a separate md-file under samples/. If that information is preferred to be placed somewhere else, tell me and I'll move it.

This pull request does not include the possibility to collect data only for a specific module, nor the possibility to add compression as argument. If that's wanted functionality, I can add that later.

philippelt commented 4 years ago

You have done a good job.

When you will have some more time, you may add in the documentation the hints you mention in the comments of the previous PR for customizing your code.

It could help others to propose contributions to your code !

joebe975 commented 4 years ago

Are you referring to the compression, or have I missed other aspects as well?

philippelt commented 4 years ago

I was just refering to your last comment on PR #38

joebe975 commented 4 years ago

This pull request fixes (including documentation) the first part of that comment as you can now change the rate limits directly from argument, and the default is set to lower than the maximum.

The second part of the comment was related to the compression, which I will probably add sooner or later.

Thanks for quick merge and for creating this repo!