search

philipperemy / keras-tcn

Keras Temporal Convolutional Network.
MIT License
1.87k stars 454 forks source link

Tensorflow Addons #73

Open yu-iskw opened 5 years ago

yu-iskw commented 5 years ago

@philipperemy

I would like to expand the code with tf.keras. Can I modify the code to release it on pypi? I know the license is MIT, but I would like to confirm that just in case.

philipperemy commented 5 years ago

@yu-iskw hey! I'm still not sure exactly at the moment what would be the impact of this change. I know Keras is now somehow part of Tensorflow but can still be imported with import keras instead of import tf.keras. So that would force users running on theanos/CNTK to move to tensorflow? I'm not sure how many users still use those frameworks with Keras. Or maybe we could have two different wheels. One for pure Keras and one for TF+Keras during the transition? What do you think?

yu-iskw commented 5 years ago

Hi, thank you for replying the message. I am not sure how many people the change will impacts. As for me, one of the benefit to modify it with tf.keras is I am able to use tf.data.Dataset API. Especially, TFRecord is very convenient to use a large data set.

So what I want to do is to support the package to both of pure keras and tf.keras while the transition from keras to tf.keras is going. I don’t know the future plans of migrating between them. However, it would be worthwhile supporting both at the moment.

philipperemy commented 5 years ago

@yu-iskw sure if we can support both at the same time it could be nice! I guess that would be the best solution.

philipperemy commented 5 years ago

As long as nobody is impacted by the change I'm fine with that. If we have a way to import tf.keras instead of keras when tensorflow.keras is present, without breaking anything, then let's do that.

evanatyourservice commented 4 years ago

I’ll be testing this later today using tensorflow 2.0 in a colab notebook, I’ll report back if I have to make any changes to make it run smoothly.

Edit: never mind I now see that pull req!

philipperemy commented 4 years ago

👍

shun-lin commented 4 years ago

Hi!

I recently came across TCN and wanted to try it out with tf 2.0 and tf.keras. @philipperemy thank you so much for the keras version implementation :). If we also want to support tf.keras, I think another great place we can put it on for more visibility is tensorflow addons. @philipperemy may I help out with porting the tcn layer portion of the code to tensorflow.addons.layers?

philipperemy commented 4 years ago

@shun-lin if you can help out porting the TCN layer portion to tensorflow addons layers, it would be amazing!!

philipperemy commented 4 years ago

The TF2.0 and tf.keras is on the way :)

shun-lin commented 4 years ago

@philipperemy thanks :)