philipperemy / n-beats

Keras/Pytorch implementation of N-BEATS: Neural basis expansion analysis for interpretable time series forecasting.
MIT License
864 stars 166 forks source link

Is torchvision really a requirement? #42

Closed jroakes closed 3 years ago

jroakes commented 3 years ago

I am having issues installing for Windows based on a requirement for torchvision.

In the setup.py file, the following requirements are listed:

    INSTALL_REQUIRES.extend([
        'torch',
        'torchvision'
    ])

But I don't find any usage of torchvision in the code. Is this really a needed requirement?

philipperemy commented 3 years ago

@jroakes sorry for the late reply. It's not necessary you are right. I am going to remove it from the deps.

philipperemy commented 3 years ago

Updated in https://github.com/philipperemy/n-beats/commit/e13239350de9a30d4c0689665f9b5ca3d5a19824