search

philipperemy / stanford-openie-python

Stanford Open Information Extraction made simple!
ISC License
635 stars 102 forks source link

install_dir_path logic has a mistake in it #62

Closed tdene closed 10 months ago

tdene commented 10 months ago

If install_dir_path is provided via environment variable, it remains a string: https://github.com/philipperemy/stanford-openie-python/blob/master/openie/openie.py#L23

If install_dir_path is provided via argument, it becomes a Path: https://github.com/philipperemy/stanford-openie-python/blob/master/openie/openie.py#L25

This leads to an error on the next line if install_dir_path is provided via environment variable: https://github.com/philipperemy/stanford-openie-python/blob/master/openie/openie.py#L26

philipperemy commented 10 months ago

Good catch will release a quick fix.

philipperemy commented 10 months ago

https://github.com/philipperemy/stanford-openie-python/pull/63

philipperemy commented 10 months ago

Done, you can upgrade the lib. I released 1.3.2.

pip install stanford_openie --upgrade