search

philippgille / gokv

Simple key-value store abstraction and implementations for Go (Redis, Consul, etcd, bbolt, BadgerDB, LevelDB, Memcached, DynamoDB, S3, PostgreSQL, MongoDB, CockroachDB and many more)
Mozilla Public License 2.0
724 stars 68 forks source link

Skip etcd concurrency test in CI #172

Closed philippgille closed 7 months ago

philippgille commented 7 months ago

As the code comment says, there are issues with the concurrency test for etcd in CI, but they are not reproducible locally, and also don't always happen in CI.

Previous fix attempts haven't worked:

We skip the test in CI as a temporary workaround, and before a release we can and should run all tests locally to include this one.

I also searched a bit on the web, the etcd GitHub Discussions and their Google Group.

In the future we could post a question in one of their communities.

codecov-commenter commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (1e697dc) 56.69% compared to head (4fb7703) 63.64%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #172 +/- ## ========================================== + Coverage 56.69% 63.64% +6.95% ========================================== Files 11 25 +14 Lines 822 2107 +1285 ========================================== + Hits 466 1341 +875 - Misses 327 651 +324 - Partials 29 115 +86 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.