philippgille / hello-netcoreapp

Basic .NET Core console application with additional scripts and files for building the app and creating release artifacts for a framework-dependent deployment, self-contained deployment, Docker image, Chocolatey package and AppImage
GNU General Public License v3.0
6 stars 5 forks source link

Add proper Docker image for nanoserver #46

Closed philippgille closed 6 years ago

philippgille commented 6 years ago

The Docker image for Windows nanoserver currently can't be built without the FDD already built outside of Docker. This should be improved so that building the Docker image works the same way for all operating systems and architectures.

Currently Docker images for nanoserver can only be built on Windows, and when using multi-stage builds all used containers must be Windows containers. This means the builder image must also be based on nanoserver, which again means we can't use build.sh but have to use build.ps1.

Now the same issue as in #3 arises: Add-Type -Assembly "System.IO.Compression.FileSystem" doesn't work. This can be fixed, but then other issues arise. But other than #3, this issue doesn't depend on the net461 etc. FDDs being built. Instead, another option would be to change the build scripts in such a way that an argument like fdd_linux-x64 can be passed, leading to only the given target being built. That will improve all Docker image build times and is not only for this issue, so it's an issue on its own: #45

Blocked by #45.