philippgille / serve

serve starts a simple temporary static file server in your current directory and prints your IP address to share with colleagues
Mozilla Public License 2.0
154 stars 15 forks source link

The network interface and address table looks bad on Windows #2

Closed philippgille closed 6 years ago

philippgille commented 6 years ago

On Linux it looks nice, but also just by accident. On Windows the interface names are longer and the code only fills up to 15 characters, it doesn't cut them off if a string is longer.

Also, the default network interfaces on Windows aren't called eth0 and wlan0, so use the proper Windows interface names for a good suggestion of an IP address that can be shared with colleagues.

Also, in the below example, no IPv4 address is shown for Ethernet 3, although it has one.

   Interface    |  IPv4 Address   | IPv6 Address
----------------|-----------------|----------------
vEthernet (nat) | 172.29.123.123     | foo:bar::::123
vEthernet (Standardswitch) | 172.21.123.123   | foo:bar::::124
vEthernet (DockerNAT) | 10.0.75.1       |
Ethernet 3      |                 | foo:bar::::125
Loopback Pseudo-Interface 1 | 127.0.0.1       | ::1
philippgille commented 6 years ago

We should focus on the formatting in this issue. The missing "Ethernet 3" IPv4 address is another issue: #3