search

philippj / SteamworksPy

A working Python API system for Valve's Steamworks.
MIT License
214 stars 40 forks source link

Reworked steamworks.py into Python module #26

Closed philippj closed 4 years ago

philippj commented 4 years ago

I found it initially quite hard to start working with the current implementation, so I want to suggest building an actual module.

Alongside this PR is the initial commit - which is by no means finished - of all current interface implementations except SteamController as that was deprecated some time ago.

As this is a rather big change I would appreciate your input @Gramps on this topic and to know if you approve of this.

Gramps commented 4 years ago

Wow, that is a thing of beauty, sir. I have been meaning to completely overhaul the whole thing for a while as it has become cumbersome to work with, as you noticed.

Didn't know SteamController was depreciated. Time to start gutting that out then.

I almost wonder if this should be pushed to the experimental branch to prevent issues with folks already using it or perhaps move the current master to a legacy branch.

Again, fantastic work! I will get the master branch moved to a new legacy branch then merge this in and make it our new base.

Gramps commented 4 years ago

We are go!

skyfpv commented 4 years ago

Any chance we could get someone to update the documentation on the website to mention the steamworks folder instead of steamworks.py? I'm setting this up for the first time and got pretty confused until I found this merge request. Also, thanks for all the hard work!

Gramps commented 4 years ago

Yep, it is in the works. Updates on my end have been really slow since I moved over to Godot Engine a few years a back; this project has also fallen pretty low on my priorities. That being said, I have a very large update in the works and documentation is a part of it.