Beautify test.main.js - Githubissues

philippkueng / node-neo4j

Neo4j REST API wrapper for Node.js

MIT License

211 stars 44 forks source link

Beautify test.main.js #41

Closed mattbasta closed 10 years ago

mattbasta commented 10 years ago

Cleans up the test file to be more easily readable.

philippkueng commented 10 years ago

Hi @mattbasta

Sorry just saw your PR now. ..wow that's a big commit. I'll need some time tomorrow or the day after to review it. ...thanks a bunch already.

Cheers Phil

mattbasta commented 10 years ago

The change is whitespace only. If you find any unintentional changes, definitely let me know! On Mar 18, 2014 4:30 PM, "Philipp Küng" notifications@github.com wrote:

Hi @mattbasta https://github.com/mattbasta

Sorry just saw your PR now. ..wow that's a big commit. I'll need some time tomorrow or the day after to review it. ...thanks a bunch already.

Cheers Phil

Reply to this email directly or view it on GitHubhttps://github.com/philippkueng/node-neo4j/pull/41#issuecomment-38001958 .

mattbasta commented 10 years ago

Hi Phil, have you had time to look at this?

philippkueng commented 10 years ago

Hi @mattbasta, sorry I didn't get back to you. ...i'm reviewing the changes now. ..what did you exactely? remove all the unnecessary whitespaces and convert leftover tabs to whitespaces? with my diff-tool it's kind difficult to see it.

mattbasta commented 10 years ago

I essentially just ran the source through a JS beautifier (it's been a while and I don't remember which one off the top of my head, but it was probably http://jsbeautifier.org/). Some notable differences:

Consistent whitespace
Consistent indentation
Comment formatting
Consistent spacing between tests

There should be no functional changes.

philippkueng commented 10 years ago

Thank you @mattbasta for your pull request. ...in case you send in further ones, could you make them smaller? it took me quite a while to work through this. thank you though for making a PR.

mattbasta commented 10 years ago

No worries. Apologies for the large change. On Jul 26, 2014 3:21 PM, "Philipp Küng" notifications@github.com wrote:

Thank you @mattbasta https://github.com/mattbasta for your pull request. ...in case you send in further ones, could you make them smaller? it took me quite a while to work through this. thank you though for making a PR.

— Reply to this email directly or view it on GitHub https://github.com/philippkueng/node-neo4j/pull/41#issuecomment-50250261 .