IMHO the timestamp should be taken when the event occurs. This is vital if you have a distributed system.
go-kit/log is a structured logger, so it should be simple to strip the ts key/value pair if you like to add a timestamp yourself.
Fair enough. The argument of adding anything (timestamp etc) to the log message can be done by the logger though and that is configurable and invoked at the time the message occurs, so can be handled outside the lib. I wouldn't expect a logger to remove stuff in order to match its own logging systematics.
In other words: the current change forces other loggers to remove data that is implementation details instead of public api.
But before it gets philosophical- happy to have this closed if you want to keep as-is, removing it is possible (while relying on internal details).
@philippseith
Fair enough. The argument of adding anything (timestamp etc) to the log message can be done by the logger though and that is configurable and invoked at the time the message occurs, so can be handled outside the lib. I wouldn't expect a logger to remove stuff in order to match its own logging systematics.
In other words: the current change forces other loggers to remove data that is implementation details instead of public api.
But before it gets philosophical- happy to have this closed if you want to keep as-is, removing it is possible (while relying on internal details).