philippseith / signalr

SignalR server and client in go
MIT License
133 stars 39 forks source link

fix client https server with query #127

Closed BenLocal closed 2 years ago

BenLocal commented 2 years ago
  1. When use NewHTTPConnection function connecting to the service, the url contains query, then negotiate path will be error eg: https://localhost:8088/hub/chat?uid=a to negotiate path is https://localhost:8088/hub/chat?uid=a/negotiate

  2. When connecting to https service, I pass in custom httpConn.client with transport, but in case of WebSockets, websocket.DialOptions does not set custom httpConn.client eg:

    conn, err := signalr.NewHTTPConnection(
        ctx,
        url,
        signalr.WithHTTPClient(&http.Client{
            Transport: &http.Transport{
                TLSClientConfig: &tls.Config{
                    InsecureSkipVerify: true,
                },
            },
        }),