philippseith / signalr

SignalR server and client in go
MIT License
131 stars 39 forks source link

fix: Reset timeout on successful Ping #181

Closed philippseith closed 11 months ago

philippseith commented 11 months ago

@renato-kristic, @gfrancois-sandbox

codecov[bot] commented 11 months ago

Codecov Report

Merging #181 (729f03b) into master (44901b4) will increase coverage by 0.18%. Report is 1 commits behind head on master. The diff coverage is 33.33%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/philippseith/signalr/pull/181/graphs/tree.svg?width=650&height=150&src=pr&token=Knk0CjgbuW&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Philipp+Seith)](https://app.codecov.io/gh/philippseith/signalr/pull/181?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Philipp+Seith) ```diff @@ Coverage Diff @@ ## master #181 +/- ## ========================================== + Coverage 80.06% 80.25% +0.18% ========================================== Files 30 30 Lines 2353 2355 +2 ========================================== + Hits 1884 1890 +6 + Misses 341 339 -2 + Partials 128 126 -2 ``` | [Files](https://app.codecov.io/gh/philippseith/signalr/pull/181?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Philipp+Seith) | Coverage Δ | | |---|---|---| | [loop.go](https://app.codecov.io/gh/philippseith/signalr/pull/181?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Philipp+Seith#diff-bG9vcC5nbw==) | `94.77% <33.33%> (-0.77%)` | :arrow_down: | ... and [5 files with indirect coverage changes](https://app.codecov.io/gh/philippseith/signalr/pull/181/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Philipp+Seith) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/philippseith/signalr/pull/181?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Philipp+Seith). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Philipp+Seith) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/philippseith/signalr/pull/181?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Philipp+Seith). Last update [44901b4...729f03b](https://app.codecov.io/gh/philippseith/signalr/pull/181?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Philipp+Seith). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Philipp+Seith).