search

philippseith / signalr

SignalR server and client in go
MIT License
131 stars 39 forks source link

Server should read negotiateVersion from query parameter and not header #186

Closed dillondrobena closed 8 months ago

dillondrobena commented 9 months ago

According to the Docs

In the POST request the client sends a query string parameter with the key "negotiateVersion" and the value as the negotiate protocol version it would like to use.

I noticed the route that handles POST /negotiate tries to read negotiateVersion from the request header, which defaults to version 0 if it is not found. This causes issues on some clients trying to negotiate with version 1 but the server uses version 0 since it is not checking the query parameters.