fix: properly stop client on Stop

philippseith / signalr

SignalR server and client in go

MIT License

131 stars 39 forks source link

fix: properly stop client on Stop #188

Closed sruehl closed 7 months ago

sruehl commented 9 months ago

This is a attempt to fix the client not closing issue mentioned in https://github.com/philippseith/signalr/issues/189

sruehl commented 9 months ago

~At the moment the added test would run with the unchanged code in client, which is due the client setting the state immediately on master~

philippseith commented 7 months ago

Can you please change the usage of partyBase.wgin client to party.waitGroup()? Then I will merge the PR

sruehl commented 7 months ago

updated. Please double check if I understood you right because I changed c.wg.Add... to c.partyBase.waitGroup().Add. I could not find a reference to party so I implied you meant this by that.