search

philippta / flyscrape

Flyscrape is a command-line web scraping tool designed for those without advanced programming skills.
https://flyscrape.com
Mozilla Public License 2.0
1.02k stars 29 forks source link

feature: support ts config #23

Closed sc0Vu closed 9 months ago

sc0Vu commented 9 months ago

In this PR, I expose build options to support ts file.

philippta commented 9 months ago

I like the idea of adding typescript support but this is a little weak. There is too much reliance on any in the example script, which does not add much of a benefit.

Ideally there are some type definitions for the config and functions but I’m not too familiar with typescript.

I would also prefer to not leak esbuild configuration into the wider package scope i.e. outside of the Compile function.

It would be best to create an issue for this first to track progress and ideas.