search

philiprodrigues / appfwk-externals

Code to build DUNE DAQ application externals
0 stars 2 forks source link

Split up patch to two as its version dependent and explicitly depend on cetmodules #6

Closed brettviren closed 4 years ago

brettviren commented 4 years ago

This is needed for #5 for me to make these work:

$ spack install trace@3.15.09
$ spack install trace@stable

@philiprodrigues I wonder why the lack of cetmodules didn't trip up your builds. Maybe you have some mixing of UPS + Spack environments? Or, maybe building via spack install appfwk hides this missing dependency?

philiprodrigues commented 4 years ago

Oh, this was my mistake, I didn't test the 3.15.09 build. It looks like the only difference between 3.15.09 and the stable branch at the moment is this commit, which makes the cetmodules dependency optional:

https://cdcvs.fnal.gov/redmine/projects/trace/repository/git/revisions/41ecd3321ec5ee9b83bcd92c365636b331294d17

Does trace@stable build for you without the cetmodules dependency? If so, I think make that 

depends_on('cetmodules@1.01.01:', type='build', when='3.15.09')

and it's good to go

brettviren commented 4 years ago

Yes, limiting the cetmodules dependency to 3.15.09 lets trace@stable still install. Thanks for noticing this.

Locally I now have commits for #6 and #7 interleaved so maybe I push what I have to #7 and we close #6?

(I need to figure out a way to keep this kind of "PR branching" separate!)

brettviren commented 4 years ago

Closing as it is merged into #7.