search

philips-labs / terraform-aws-github-runner

Terraform module for scalable GitHub action runners on AWS
https://philips-labs.github.io/terraform-aws-github-runner/
MIT License
2.63k stars 627 forks source link

SSM parameters not cleaned up #1808

Closed samuelb closed 1 year ago

samuelb commented 2 years ago

Hello

I found today that we have hundreds of AWS System Manager Parameters defined. The lambda is creating those when starting a new runner instance to pass the authentication token and other parameters to the runner agent software.

It's so many, that aws ssm describe-parameters runs into rate limits. It's not only about keeping things clean, but also it has functional impact.

Can a cleanup of unneeded parameters get implemented?

samuelb commented 2 years ago

To clean up the parameters once, I ran

aws ssm describe-parameters --filter "Key=Name,Values=action-runner-" | jq -r ".Parameters[].Name" | xargs -n 10  aws ssm delete-parameters --names
github-actions[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs. Thank you for your contributions.

tonyc-blastpoint commented 2 years ago

Still an issue.

tonyc-blastpoint commented 2 years ago

/remove-lifecycle stale

github-actions[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs. Thank you for your contributions.

tonyc-blastpoint commented 2 years ago

Still an issue.

github-actions[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs. Thank you for your contributions.

tonyc-blastpoint commented 2 years ago

Still an issue.

github-actions[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs. Thank you for your contributions.

tonyc-blastpoint commented 2 years ago

Still an issue.

github-actions[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs. Thank you for your contributions.

tonyc-blastpoint commented 2 years ago

Still an issue!

github-actions[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs. Thank you for your contributions.

tonyc-blastpoint commented 2 years ago

...still an issue.

github-actions[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs. Thank you for your contributions.

samuelb commented 2 years ago

Still an issue, but a PR is on the way

github-actions[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs. Thank you for your contributions.

chasemgray commented 1 year ago

@samuelb did your PR get merged to fix this?

samuelb commented 1 year ago

I meant PR #2587. I'm not the author of it and no, it didn't got merged till now.

mbeliayeu commented 1 year ago

Still an issue, but PR is closed as stale

chasemgray commented 1 year ago

Is anyone going to reopen and merge the PR? We hit a 100,000 SSM parameter limit due to old parameters not being cleaned up.