Tags don't propogate into ec2 fleet specification or ssm put parameter

[mchieco]

I have the need for all resources in the project to be tagged. There is a tags field currently that states: Map of tags that will be added to created resources. By default resources will be tagged with name and environment.

This isn't fully true, inside runner.ts it doesn't add those tags to the ec2 fleet as well as the ssm parameter. I can make these changes and create a PR. Just wanted to know if this was intentional or not since I've ran into issues with these 2 specific spots on my end.

[npalm]

I am not 100% sure tags are propagated to all resources created by Terraform. We let the provider set tags to all resources. EC2 instances are created by the lambda, and therefore not manged via Terraform. The launch template should use the tags merged with runner_ec2_tags to set tags for EC2 instances and volumes.

In case here is a bug feel free to propose a PR

[mchieco]

I've been using the next branch since i am testing out the multi runner functionality. Is it okay if I make this PR off of that branch? The contribution guide says to branch off of develop and all the workflows are off of that as well. Just want to get this into the right spot!

[npalm]

Sorry for the late response, yes we welcome a PR to support the need for tagging.

[github-actions[bot]]

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs. Thank you for your contributions.