philips-labs / terraform-aws-github-runner

Terraform module for scalable GitHub action runners on AWS
https://philips-labs.github.io/terraform-aws-github-runner/
MIT License
2.62k stars 627 forks source link

Missing ami_id_ssm_parameter_name parameter from multi-runner #2883

Closed scatybeneva closed 1 year ago

scatybeneva commented 1 year ago

The optional parameter ami_id_ssm_parameter_name that can be used in a single runner is not defined with the multi-runner module so it has no effect. Would be very useful to override ami_filter in the same way with multi-runner.

npalm commented 1 year ago

Here you can find an example how to overwrite the AMI including a custom user_data script

https://github.com/philips-labs/terraform-aws-github-runner/blob/a1013e91f0fe380ff7988e20e9efea78e73acea6/examples/multi-runner/main.tf#L45-L93

scatybeneva commented 1 year ago

Yeah that works fine, but I'm talking about not using an ami_filter but to specify an SSM parameter store path to fetch the AMI ID built from an external process. This was added by this.

Looking at the code, ami_id_ssm_parameter_name isn't set in the multi-runner module. So the scale-up lambda module won't set the corresponding env var either nor the policy to allow access to the SSM parameter.

github-actions[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs. Thank you for your contributions.