philips-labs / terraform-aws-github-runner

Terraform module for scalable GitHub action runners on AWS
https://philips-labs.github.io/terraform-aws-github-runner/
MIT License
2.44k stars 578 forks source link

fix(webhook): Don't set `${SQS_WORKFLOW_JOB_QUEUE}` to empty string #3943

Closed iainlane closed 1 week ago

iainlane commented 2 weeks ago

We currently indicate that this feature is disabled by setting the env var to an empty string. But instead we could omit it, to avoid polluting the environment, and causing a warning to be logged.

This is a companion to #3942. That one stops the warning mentioned, this one fixes the original cause by not setting the env var in the first place. Both could be merged, ideally.