philips-labs / terraform-aws-github-runner

Terraform module for scalable GitHub action runners on AWS
https://philips-labs.github.io/terraform-aws-github-runner/
MIT License
2.44k stars 578 forks source link

Ephemeral runners based on windows-core-2022 start but never connect to github due to missing argument on run.cmd #3950

Open ardole opened 1 week ago

ardole commented 1 week ago

Base image example windows core 2022 always install the runner as a service.

$action = New-ScheduledTaskAction -WorkingDirectory "$pwd" -Execute "run.cmd"

This fail when enable_jit_config or enable_ephemeral_runners is true, because of missing -Argument "--jitconfig $config"

Without this, runner will never be connected to github.

Context:

npalm commented 3 days ago

Tested the PR, was not able to got it working yet.