fix: improve logging when there is an error retrieving ssm parameters

philips-labs / terraform-aws-github-runner

Terraform module for scalable GitHub action runners on AWS

https://philips-labs.github.io/terraform-aws-github-runner/

MIT License

2.55k stars 611 forks source link

fix: improve logging when there is an error retrieving ssm parameters #3962

Closed Brend-Smits closed 3 months ago

Brend-Smits commented 3 months ago

In case the AMI ID Parameter was set to something that did not exist, it would produce an obscure error: "message": "Ignoring error: UnknownError". Now it produces better error messages: "message": "Ignoring error: Error: Failed to lookup runner AMI ID from SSM parameter: /github-action-runners/staging/ubuntu-x64/runners/config/ami-id,\n ParameterNotFound: UnknownError",

Signed-off-by: Brend Smits brend.smits@philips.com