search

philips-labs / terraform-aws-github-runner

Terraform module for scalable GitHub action runners on AWS
https://philips-labs.github.io/terraform-aws-github-runner/
MIT License
2.6k stars 623 forks source link

Align instance tagging #4026

Open npalm opened 3 months ago

npalm commented 3 months ago

Problem

Currently the formatting of tag the instances is not consequent. For example

Proposal

Format all tags ghr:* with snake case. Any tag namge chaged could cause a breaking tchagen. So there where scale down is depended on case the implementation should be done in two steps. Ensure that the scale down function can handle the old tags as well, to make an update fluent.

github-actions[bot] commented 1 week ago

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs. Thank you for your contributions.