philips-labs / terraform-aws-github-runner

Terraform module for scalable GitHub action runners on AWS
https://philips-labs.github.io/terraform-aws-github-runner/
MIT License
2.62k stars 627 forks source link

Multi-region deployments not successful due to global IAM role names #4206

Closed evanstachowiak closed 3 weeks ago

evanstachowiak commented 1 month ago

Hi,

I would like to deploy this module into multiple regions within the same account, however, the IAM roles are not configurable and are not unique across module instantiations. IAM role names are create within a global namespace, so this causes errors in the deployment.

Is there any way to support configurable names for the IAM roles? Or at least support adding the region into the naming?

Thanks for this module, otherwise it is working wonderfully!

npalm commented 4 weeks ago

We have multiple deployments in a single account, you can set the prefix variable to different values. This will be used as part of the role name (and almost any resource) to make name unique.

evanstachowiak commented 3 weeks ago

Oh, that's perfect, sorry I didn't see that. Thank you!