philips-software / amp-devcontainer

amp-devcontainer is a fully loaded devcontainer useable for, embedded, C++ or Rust development
MIT License
98 stars 4 forks source link

feat: add udev to amp-devcontainer-cpp #572

Closed richardapeters closed 1 day ago

richardapeters commented 3 days ago

Pull Request

Description of changes

This PR adds the udev package to amp-devcontainer-cpp to make device nodes and rules available to the container. This enables usage of attached hardware/embedded devices in the container. Examples are access to serial ports or debuggers for debugging and flashing.

Checklist

github-actions[bot] commented 3 days ago

Compressed layer size comparison

Comparing ghcr.io/philips-software/amp-devcontainer-rust:latest to ghcr.io/philips-software/amp-devcontainer-rust@sha256:d4313b364c07c50fdef3133f1c11d98f1d71f9606832cc096142400616354bcc

OS/Platform Previous Size Current Size Delta
linux/amd64 433.13M 433.13M 0.00 (+0.00%)
linux/arm64 572.34M 572.34M 0.00 (+0.00%)
github-actions[bot] commented 3 days ago

πŸ¦™ MegaLinter status: βœ… SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
βœ… ACTION actionlint 16 0 0.09s
βœ… DOCKERFILE hadolint 2 0 0.44s
βœ… JSON prettier 16 1 0 0.74s
βœ… JSON v8r 15 0 19.24s
βœ… MARKDOWN markdownlint 8 0 0 1.03s
βœ… MARKDOWN markdown-table-formatter 8 0 0 0.25s
βœ… REPOSITORY checkov yes no 15.9s
βœ… REPOSITORY gitleaks yes no 0.37s
βœ… REPOSITORY git_diff yes no 0.01s
βœ… REPOSITORY grype yes no 13.19s
βœ… REPOSITORY secretlint yes no 1.31s
βœ… REPOSITORY trivy yes no 6.29s
βœ… REPOSITORY trivy-sbom yes no 1.11s
βœ… REPOSITORY trufflehog yes no 3.06s
βœ… SPELL lychee 55 0 1.03s
βœ… YAML prettier 21 0 0 1.09s
βœ… YAML v8r 21 0 12.37s
βœ… YAML yamllint 21 0 0.57s

See detailed report in MegaLinter reports

_MegaLinter is graciously provided by OX Security_

github-actions[bot] commented 3 days ago

Test Results

 2 files  Β±0   2 suites  Β±0   52s :stopwatch: Β±0s 26 tests Β±0  26 :white_check_mark: Β±0  0 :zzz: Β±0  0 :x: Β±0  28 runsβ€Š Β±0  28 :white_check_mark: Β±0  0 :zzz: Β±0  0 :x: Β±0 

Results for commit 30c38bc6. ± Comparison against base commit ac2c8d62.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 2 days ago

Compressed layer size comparison

Comparing ghcr.io/philips-software/amp-devcontainer-cpp:latest to ghcr.io/philips-software/amp-devcontainer-cpp@sha256:a05490c6b7fce8c3a4f0117eac71af29fefceae5d6820df50f286d8824b65a16

OS/Platform Previous Size Current Size Delta
linux/amd64 641.11M 653.79M 12.68M (+1.98%)
linux/arm64 633.45M 646.22M 12.77M (+2.02%)
sonarcloud[bot] commented 2 days ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

github-actions[bot] commented 1 day ago

Pull Request Report (#572)

Static measures

Description Value
Number of added lines 1
Number of deleted lines 0
Number of changed files 1
Number of commits 4
Number of reviews 3
Number of comments (w/o review comments) 5
Number of reviews that contains a comment to resolve 2
Number of reviews that requested a change from the author 0
Number of reviews that approved the Pull Request 1
Get the total number of participants of a Pull Request 6

Time related measures

Description Value
PR lead time (from creation to close of PR) 1.1 Days
Time that was spend on the branch before the PR was created 20 Sec
Time that was spend on the branch before the PR was merged 1.1 Days
Time to merge after last review 2 Hours

Status check related measures

Description Value
Total runtime for last status check run (Workflow for PR) 2.2 Hours
Total time spend in last status check run on PR 5.2 Hours
github-actions[bot] commented 1 day ago

πŸŽ‰ Hooray! The changes in this pull request went live with the release of v5.2.0 πŸŽ‰