search

philips-software / powershell-cf-api

PowerShell module can deploy and teardown CloudFoundry spaces and services via a json definition file
MIT License
5 stars 6 forks source link

Parameter for clear text password #25

Open lipkau opened 4 years ago

lipkau commented 4 years ago

Passing password as clear text is a bad practice (as the exceptions for PSScriptAnalyzer point out). I would recommend changing to a [PSCredential] object, which is more "powershelly" and you can still fetch the user and password out of the object

This is a breaking change, as it will change the signature of the function

marklindell commented 4 years ago

I agree. When I wrote it not understand this and I also did not have PSScriptAnalyzer integrated. Thanks for the issue.

lipkau commented 4 years ago

will submit the PR once #23 is merged