search

philipsorst / angular-rest-springsecurity

An example AngularJS Application that uses a Spring Security protected Jersey REST backend based on Hibernate/JPA
Apache License 2.0
620 stars 367 forks source link

Unit Tests for improved test coverage #23

Open mfarid opened 8 years ago

mfarid commented 8 years ago

Hi Philip

My name is Farid. I'm a developer with great interest in making open source contributions to popular projects.

My company - DevFactory - is sponsoring me to improve unit test coverage in open source projects.

I have analyzed angular-rest-springsecurity and observed that there is room for improvement of coverage. The results indicate that the project has:

Coverage: 0%, Total Lines: 736

If you are interested in having us work towards improving the project’s coverage to 80%, please let me know and we will add it to our pipeline. Our first step will be to create a pull request with a sample. Once you approve it, we'll follow up with one or two more pull requests. Our target is to increase code coverage to above 80 percent.

For an example of our work, please see these Pull Requests accepted by the community:

I'm looking forward to your confirmation.

Thank you, Mohd Farid Open Source Code Coverage Team DevFactory

sesepehr commented 8 years ago

hi thanks for recommendation, Thank you

sepehr naderi

On Sun, Jan 17, 2016 at 11:07 AM, Mohd Farid notifications@github.com wrote:

Hi Philip

My name is Farid. I'm a developer with great interest in making open source contributions to popular projects.

My company - DevFactory - is sponsoring me to improve unit test coverage in open source projects.

I have analyzed angular-rest-springsecurity and observed that there is room for improvement of coverage. The results indicate that the project has:

Coverage: 0%, Total Lines: 736

If you are interested in having us work towards improving the project’s coverage to 80%, please let me know and we will add it to our pipeline. Our first step will be to create a pull request with a sample. Once you approve it, we'll follow up with one or two more pull requests. Our target is to increase code coverage to above 80 percent.

For an example of our work, please see these Pull Requests accepted by the community:

I'm looking forward to your confirmation.

Thank you, Mohd Farid Open Source Code Coverage Team DevFactory

— Reply to this email directly or view it on GitHub https://github.com/philipsorst/angular-rest-springsecurity/issues/23.

mfarid commented 8 years ago

I have raised a small Pull Request that introduces testing into the project. It also tests TokenUtils class. Please review the same and share feedback. https://github.com/philipsorst/angular-rest-springsecurity/pull/24

Once you approve the same, I will raise a PR for the rest of the classes.