search

philipwalton / flexbugs

A community-curated list of flexbox issues and cross-browser workarounds for them.
MIT License
13.63k stars 495 forks source link

Webkit #148826 and #169082 have been fixed #205

Closed mkurz closed 6 years ago

mkurz commented 7 years ago

https://bugs.webkit.org/show_bug.cgi?id=148826 was marked as duplicate of https://bugs.webkit.org/show_bug.cgi?id=169082 which has been marked as fixed half an hour ago.

We probably want to wait to merge this pull request until Safari 10.1 got released.

philipwalton commented 7 years ago

Thanks, yes lets wait until they're released in Safari to merge.

mkurz commented 7 years ago

Safari 11 is out and this should finally be ok to get merged.

However I don't have access to an Apple machine right now so could someone check if it is really working correctly in SF11?

https://codepen.io/philipwalton/pen/wKBqdY should look like this:

correct

Thanks!

mkurz commented 7 years ago

Ping @philipwalton

alanhussey commented 6 years ago

Confirmed fixed:

screen shot 2017-10-25 at 2 43 31 pm

mkurz commented 6 years ago

Thanks for confirming @alanhussey

mkurz commented 6 years ago

@philipwalton this can be merged.

philipwalton commented 6 years ago

Yep, thanks!