`flex: 1 1 0%` is different from flex: `1 1 0px`

philipwalton / flexbugs

A community-curated list of flexbox issues and cross-browser workarounds for them.

MIT License

13.63k stars 495 forks source link

`flex: 1 1 0%` is different from flex: `1 1 0px` #266

Open rpellerin opened 5 years ago

rpellerin commented 5 years ago

Regarding bug 4, we should not advise people to replace flex shorthand declarations that contain a unitless third argument with percentages instead of pixels, for flex: 1 1 0% is different from flex: 1 1 0px. More on the topic: https://bugs.chromium.org/p/chromium/issues/detail?id=495306

garrettw commented 5 years ago

Generally it is advisable to never use units with 0 in the first place.

rpellerin commented 5 years ago

We agree on this. But sometimes the code is already there and you just can't replace every occurrence.