philipwatson / videojsx-vast-plugin

A video.js plugin to allow the player to serve adverts using VAST
Other
32 stars 23 forks source link

restore videojs7 support #44

Closed nachoaguirre closed 4 weeks ago

nachoaguirre commented 1 month ago

Currently videojsx-vast-plugin does not work with version 7 of video.js.

To restore compatibility with this version, a check of the version currently being used has been added and the options are merged based on that.

With this small change, compatibility is added.

A demo page for video.js 7 has been added along with videojs-contrib-ads v6.9.0

klaussilveira commented 4 weeks ago

@philipwatson can you please take a look at this? This solves our current issue :eyes:

philipwatson commented 4 weeks ago

Looks good, thank you @nachoaguirre !