philj56 / gbcc

Cross-platform Game Boy emulator written in C
https://gbcc.github.io
Other
41 stars 8 forks source link

doki x doki sasete broken sprites #12

Closed georgehb closed 5 years ago

georgehb commented 5 years ago

broken sprites in 9228f9480b910ba16709a79cc647e166f5deb5ac

2018-11-14-230944_

philj56 commented 5 years ago

I think that's the wrong commit, it's actually ffb42fea659769889889deba1dc946259d1b2791. Either way, at first glance this is due to a broken HDMA implementation

philj56 commented 5 years ago

This has been fixed in 6b5778937cf2e5c08162deccd78e2e0cbafd95f5. The game was being told that the HDMA transfer had finished immediately, causing it to start switching ROM banks, so that the HDMA transfers were from random places in memory giving the corrupted sprites seen.