search

phillbaker / digitalocean-node

Unofficial node client for the v2 DigitalOcean API
http://phillbaker.github.io/digitalocean-node
MIT License
67 stars 16 forks source link

Fix for #12 since volume detaching returns 202 #13

Closed omgimanerd closed 7 years ago

omgimanerd commented 7 years ago

According to the DigitalOcean documentation, volume attaching, detaching, and resizing return a 202 status code. Let me know if this should be solved a different way. I'm still not entirely familiar with the codebase.

omgimanerd commented 7 years ago

The unit tests failed after 3ecb4cde5312447e865119a01a9a26ae86cb3762, so I updated them appropriately. Please let me know if I overlooked something.

phillbaker commented 7 years ago

Great, thanks! Can you squash your commits?

On Wed, Jan 18, 2017 at 5:06 PM Alvin Lin notifications@github.com wrote:

The unit tests failed after 3ecb4cd https://github.com/phillbaker/digitalocean-node/commit/3ecb4cde5312447e865119a01a9a26ae86cb3762, so I updated them appropriately. Please let me know if I overlooked something.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/phillbaker/digitalocean-node/pull/13#issuecomment-273616814, or mute the thread https://github.com/notifications/unsubscribe-auth/AAFxKREOOP89eIPja7R5_URlH1Tdsdf5ks5rTozPgaJpZM4LnbkO .

omgimanerd commented 7 years ago

Sure thing, did I miss anything?

phillbaker commented 7 years ago

Looks good, thanks. I'll get a version bump out.

omgimanerd commented 7 years ago

Could you release this on npm please?

phillbaker commented 7 years ago

Whoops, pushed!