search

phillbaker / terraform-provider-elasticsearch

An elasticsearch provider for terraform
https://registry.terraform.io/providers/phillbaker/elasticsearch
Mozilla Public License 2.0
306 stars 134 forks source link

use new _index_template endpoints for ES7 #295

Closed digitalkaoz closed 2 years ago

digitalkaoz commented 2 years ago

see https://github.com/olivere/elastic/pull/1415

phillbaker commented 2 years ago

Hi, can you elaborate a bit on the intent here?

If I’m understanding correctly, this is compatible only with ES v7.8+. It’d be a breaking change for other versions.

On Mon, Jul 11, 2022 at 10:24 AM Robert Schönthal @.***> wrote:

see olivere/elastic#1415 https://github.com/olivere/elastic/pull/1415

You can view, comment on, or merge this pull request online at:

https://github.com/phillbaker/terraform-provider-elasticsearch/pull/295 Commit Summary

File Changes

(1 file https://github.com/phillbaker/terraform-provider-elasticsearch/pull/295/files )

Patch Links:

- https://github.com/phillbaker/terraform-provider-elasticsearch/pull/295.patch

https://github.com/phillbaker/terraform-provider-elasticsearch/pull/295.diff

— Reply to this email directly, view it on GitHub https://github.com/phillbaker/terraform-provider-elasticsearch/pull/295, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAXCKKTDOU3OOPZEKX6HH3VTQVCRANCNFSM53HWOTMA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

digitalkaoz commented 2 years ago

Mh, yeah you are right, its only 7.8+. The _template endpoint is deprecated and will be removed soon. Maybe check the minor version too?

phillbaker commented 2 years ago

That sounds fine to me!

On Tue, Jul 12, 2022 at 1:17 AM Robert Schönthal @.***> wrote:

Mh, yeah you are right, its only 7.8+. The _template endpoint is deprecated and will be removed soon. Maybe check the minor version too?

— Reply to this email directly, view it on GitHub https://github.com/phillbaker/terraform-provider-elasticsearch/pull/295#issuecomment-1181324839, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAXCKLAZ477HISQMBGSENTVTT5VLANCNFSM53HWOTMA . You are receiving this because you commented.Message ID: @.*** com>

phillbaker commented 2 years ago

Hi @digitalkaoz are you able to update this PR?

phillbaker commented 2 years ago

Hi @digitalkaoz I'm going to close this PR out since it hasn't been updated. Please re-open if you're able to update.