Open cgroschupp opened 1 year ago
Thanks for the PR, please make sure that the tests cover this functionality!
On Wed, Mar 22, 2023 at 12:07 PM Christian Groschupp < @.***> wrote:
Fixes: #344 https://github.com/phillbaker/terraform-provider-elasticsearch/issues/344
You can view, comment on, or merge this pull request online at:
https://github.com/phillbaker/terraform-provider-elasticsearch/pull/345 Commit Summary
- b5bf0e0 https://github.com/phillbaker/terraform-provider-elasticsearch/pull/345/commits/b5bf0e0a9fe6f9a91b3f782b9e42a13c9ea79ab5 feat: add kibana alert update
File Changes
(1 file https://github.com/phillbaker/terraform-provider-elasticsearch/pull/345/files )
- M es/resource_elasticsearch_kibana_alert.go https://github.com/phillbaker/terraform-provider-elasticsearch/pull/345/files#diff-093753ffb213e844c331ae0070b41968decb3639886d72beb35b66bebfafed1c (66)
Patch Links:
- https://github.com/phillbaker/terraform-provider-elasticsearch/pull/345.patch
https://github.com/phillbaker/terraform-provider-elasticsearch/pull/345.diff
— Reply to this email directly, view it on GitHub https://github.com/phillbaker/terraform-provider-elasticsearch/pull/345, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAXCKJB7QXX6CP6UQYVN43W5MPVDANCNFSM6AAAAAAWEBCMEE . You are receiving this because you are subscribed to this thread.Message ID: @.***>
Following up on this, it looks like the PR failed to pass the linters, would you like to have a look?
Fixes: #344