phillbush / xmenu

a x11 menu utility
Other
296 stars 26 forks source link

Make standard for non-GNU #23

Closed astralchan closed 3 years ago

astralchan commented 3 years ago

Here there seems to be interest in making this app as portable as possible. If that's the case, the SHELL variable really should be set "to avoid trouble on systems where the SHELL variable might be inherited from the environment" (GNU Makefile Basics). On GNU's Makefile basics, it states:

Every Makefile should contain this line:

SHELL = /bin/sh

While this isn't really required on GNU's version of Make, and thus you don't see it on GNU / Linux apps as often, this is a good practice especially when dealing with non-GNU versions of Make. This also isn't necessarily a bad idea to include on GNU version of Make as well.

phillbush commented 3 years ago

Merged! Thanks for the PR!