search

phillc73 / abettor

An R package for connecting to the online betting exchange Betfair, via their API-NG product, using JSON-RPC.
Other
51 stars 36 forks source link

Dashee87 patch 1 #10

Closed dashee87 closed 8 years ago

dashee87 commented 8 years ago

Hi,

Hopefully, I'm doing this right!

Most of the functions are additions to the current repository. loginBF was edited to incorporate basic error handling (it now returns a string indicating success/failure). I also changed the Readme to state that this package wouldn't be a limited list of API functions. I'm happy to create functions for all possible API calls (even derivatives like cashout, which would be a combination of number of functions).

phillc73 commented 8 years ago

A general comment: Can you try to limit the width of comments to 80 characters?

If you're using RStudio as your IDE, highlight the comment text only, then select "Code/Reflow Comment" from the menus (or the keyboard shortcut).

It might also be worth highlighting the code and using "Code/Reformat Code" too. I know I didn't do this in the original package, but I think it does make things more readable (I've learned since).

I'm going to close the pull request, but really do want to incorporate all your hard work. If you could update the README and the comment width, I'd be very happy to have another look.